Periodic sync of OKD samples#683
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughUpdated Open Liberty ImageStream entries to bump version from 26.0.0.2 to 26.0.0.4 across Java 8, 11, 17, and 21: tag names, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aroyoredhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json (1)
17-99:⚠️ Potential issue | 🔴 CriticalThe Docker images for Open Liberty 26.0.0.3 do not exist at the specified registry and must be available before merge.
All four referenced images (26.0.0.3-java8, java11, java17, java21) at
icr.io/appcafe/open-liberty-s2iare inaccessible and will cause deployment failures. Either push these images to the registry or revert the version references to available images.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json` around lines 17 - 99, The image stream entries named "26.0.0.3-java8", "26.0.0.3-java11", "26.0.0.3-java17", and "26.0.0.3-java21" reference non-existent images in the from.name fields (e.g. "icr.io/appcafe/open-liberty-s2i:26.0.0.3-java8") and must be fixed; either push the corresponding images to icr.io with those tags or update each from.name to a confirmed available tag (or revert the name fields back to the last-known-working tag) and ensure the display name annotations (openshift.io/display-name) stay consistent, then verify by doing a docker pull of each updated from.name.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json`:
- Around line 17-99: The image stream entries named "26.0.0.3-java8",
"26.0.0.3-java11", "26.0.0.3-java17", and "26.0.0.3-java21" reference
non-existent images in the from.name fields (e.g.
"icr.io/appcafe/open-liberty-s2i:26.0.0.3-java8") and must be fixed; either push
the corresponding images to icr.io with those tags or update each from.name to a
confirmed available tag (or revert the name fields back to the
last-known-working tag) and ensure the display name annotations
(openshift.io/display-name) stay consistent, then verify by doing a docker pull
of each updated from.name.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7a8aae5f-ff07-4d07-8575-f3ac59b443f6
📒 Files selected for processing (1)
assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json
aroyoredhat
force-pushed
the
periodic-okd-sync
branch
from
aa6d064 to
e43e0f0
Compare
aroyoredhat
force-pushed
the
periodic-okd-sync
branch
from
e43e0f0 to
7cf53e6
Compare
|
@aroyoredhat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Syncing the latest samples from the library to OKD.
Created using https://github.com/aroyoredhat/trigger-test-samples-build
Summary by CodeRabbit